Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EAH - Typescript state_monitor_factory #23945

Merged
merged 4 commits into from
Oct 19, 2018
Merged

EAH - Typescript state_monitor_factory #23945

merged 4 commits into from
Oct 19, 2018

Conversation

stacey-gammon
Copy link
Contributor

Typescript state_monitor_factory

@stacey-gammon stacey-gammon changed the title Typescript state_monitor_factory EAH - Typescript state_monitor_factory Oct 10, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor Author

Failed on:

 FAIL  packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js (13.192s)
15:12:48   ● creating the build › skipInstallDependencies = false › installs node_modules as a part of build
15:12:48 
15:12:48     Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.
15:12:48 
15:12:48       60 | 
15:12:48       61 |   describe('skipInstallDependencies = false', () => {
15:12:48     > 62 |     it('installs node_modules as a part of build', async () => {
15:12:48          |     ^
15:12:48       63 |       expect(PLUGIN.skipInstallDependencies).toBe(false);
15:12:48       64 | 
15:12:48       65 |       await createBuild(PLUGIN, buildTarget, buildVersion, kibanaVersion, buildFiles);
15:12:48 
15:12:48       at Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:85:20)
15:12:48       at Suite.it (packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js:62:5)
15:12:48       at Suite.describe (packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js:61:3)
15:12:48       at Object.describe (packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js:33:1)
15:12:48 
15:12:48   ● creating the build › skipInstallDependencies = false › installs node_modules as a part of build
15:12:48 
15:12:48     Error
15:12:48 
15:12:48       Error: ENOENT: no such file or directory, open '/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/kibana/packages/kbn-plugin-helpers/tasks/build/integration_tests/__fixtures__/create_build_test_plugin/build/kibana/create_build_test_plugin/translations/es.json'
15:12:48

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@azasypkin
Copy link
Member

Cleaning up my review queue, please re-request review whenever you need it and CI is green (looks good so far though).

@azasypkin azasypkin removed their request for review October 16, 2018 11:49
@stacey-gammon stacey-gammon force-pushed the 2018-10-10-typescript-breakout-stacey branch from 910fa1c to cb4278c Compare October 16, 2018 13:30
@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor Author

Failed on the known APM Monitoring test failure, which is being fixed. Will rebase and rerun when it is merged - #24085

@stacey-gammon stacey-gammon force-pushed the 2018-10-10-typescript-breakout-stacey branch from cb4278c to 4698b87 Compare October 16, 2018 18:27
@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon stacey-gammon force-pushed the 2018-10-10-typescript-breakout-stacey branch from 4698b87 to 09db49a Compare October 16, 2018 23:49
@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor Author

Failed on:
Browser Unit Tests.historyProvider.historyProvider push updates push should push compressed state into history

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon
Copy link
Contributor Author

Green! Good for another review @azasypkin, thanks!

azasypkin
azasypkin approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/ui/public/visualize/loader/embedded_visualize_handler.ts Outdated
@@ -64,7 +64,7 @@ export class EmbeddedVisualizeHandler {
}, 100);

private dataLoaderParams: RequestHandlerParams;
private appState: AppState;
private appState?: AppState;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can be marked as readonly as it's only set in constructor.

@stacey-gammon stacey-gammon force-pushed the 2018-10-10-typescript-breakout-stacey branch from 81e5d19 to 26b797c Compare October 18, 2018 20:27
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon merged commit c5e61c3 into elastic:master Oct 19, 2018
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Oct 19, 2018
@stacey-gammon
EAH - Typescript state_monitor_factory (elastic#23945)
2d8d56c 
* Typescript state_monitor_factory

* Fix linter error with possibly undefined

* Expand typings to include hash stuff and expand the State type definition more.

* Mark readonly
@stacey-gammon stacey-gammon mentioned this pull request Oct 19, 2018
Merged
stacey-gammon added a commit that referenced this pull request Oct 23, 2018
@stacey-gammon
EAH - Typescript state_monitor_factory (#23945) (#24273)
64f1199 
* Typescript state_monitor_factory

* Fix linter error with possibly undefined

* Expand typings to include hash stuff and expand the State type definition more.

* Mark readonly
@stacey-gammon stacey-gammon deleted the 2018-10-10-typescript-breakout-stacey branch January 15, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
chore v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stacey-gammon @elasticmachine @azasypkin